Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment Lock #138

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Environment Lock #138

merged 2 commits into from
Apr 18, 2024

Conversation

nevoodoo
Copy link
Contributor

@nevoodoo nevoodoo commented Apr 17, 2024 •
edited
Loading

Description

In a bid to introduce better security permissions, we have replaced the use of SA keys to workload identity providers where possible. We will also ensure the workload federated identities are attached to an environment in the repo.

Changes

  • Updated the workflow to use WIP and separated it into two jobs, one for prod and one for dev
  • Added environment attribute to the deploy_* workflows

MattWellie
MattWellie approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@MattWellie MattWellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TLGM

@nevoodoo nevoodoo merged commit c27caa1 into main Apr 18, 2024
1 check passed
@nevoodoo nevoodoo deleted the environment-lock branch April 18, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattWellie MattWellie MattWellie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nevoodoo @MattWellie